src/test/java/org/example/vet1177/services/VetServiceTest.java (2)

122-169: Consider extracting shared fixtures for User/Vet.

User and Vet setup is duplicated across retrieval tests; small builders/helpers would reduce noise and future edit cost.

Example refactor

+    private User buildActiveUser(String name, String email) {
+        User user = new User();
+        user.setName(name);
+        user.setEmail(email);
+        user.setActive(true);
+        return user;
+    }
+
+    private Vet buildVet(User user, String licenseId) {
+        Vet vet = new Vet();
+        vet.setUser(user);
+        vet.setLicenseId(licenseId);
+        return vet;
+    }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/test/java/org/example/vet1177/services/VetServiceTest.java` around lines
122 - 169, Extract the duplicated User/Vet setup in VetServiceTest into small
private factory/helper methods (e.g., private User makeUser(String name, String
email, boolean active) and private Vet makeVet(User user, String licenseId)) and
update tests should_return_all_vets and should_return_vet_by_id to call these
helpers instead of duplicating object creation; ensure the helpers set the same
fields currently used in tests (name/email/active on User and user/licenseId on
Vet) and keep existing mock interactions (when(vetRepository.findAll())... and
when(vetRepository.findById(id))... ) and assertions unchanged.

---

39-116: Good createVet coverage overall; one branch is still missing.

You covered success + key business-rule failures well. The remaining gap is the repository-save failure path in createVet that should still surface as BusinessRuleException.

Add a focused test for the save-failure translation path

+    `@Test`
+    void should_throw_business_rule_when_persistence_fails_on_save() {
+        UUID userId = UUID.randomUUID();
+        User user = new User();
+        user.setRole(Role.OWNER);
+
+        VetRequest request = new VetRequest(userId, "LIC123", "Surgery", "Info");
+
+        when(userRepository.findById(userId)).thenReturn(Optional.of(user));
+        when(vetRepository.existsByLicenseId("LIC123")).thenReturn(false);
+        when(vetRepository.existsById(userId)).thenReturn(false);
+        when(vetRepository.save(any(Vet.class)))
+                .thenThrow(new org.springframework.dao.DataIntegrityViolationException("constraint"));
+
+        assertThrows(BusinessRuleException.class, () -> vetService.createVet(request));
+    }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/test/java/org/example/vet1177/services/VetServiceTest.java` around lines
39 - 116, Add a unit test in VetServiceTest that covers the repo-save failure
path: arrange a valid User (role OWNER) and a VetRequest, mock
userRepository.findById(...) to return the user, mock
vetRepository.existsByLicenseId(...) and existsById(...) to return false, then
stub vetRepository.save(...) to throw a RuntimeException (or generic exception)
and assert that calling vetService.createVet(request) throws
BusinessRuleException; reference createVet, vetRepository.save, and
BusinessRuleException to locate the code under test.